Trying to create a smart money supply and demand script

[SweatyMexican99]

input showZones = yes;
input length = 14;

def high = highest(high, length);
def low = lowest(low, length);
def mid = (high + low) / 2;

def buyingPressure = sum(volume * (close - low), length) / sum(volume, length);
def sellingPressure = sum(volume * (high - close), length) / sum(volume, length);

def dp = if buyingPressure > sellingPressure then 1 else -1;

plot demand;
if dp == 1 then {
demand = high;
} else {
demand = Double.NaN;
}

plot supply;
if dp == -1 then {
supply = low;
} else {
supply = Double.NaN;
}

demand.SetDefaultColor(Color.GREEN);
supply.SetDefaultColor(Color.RED);
demand.SetPaintingStrategy(PaintingStrategy.ARROW_UP);
supply.SetPaintingStrategy(PaintingStrategy.ARROW_DOWN);

if (!showZones) then {
demand.SetPaintingStrategy(PaintingStrategy.HIDDEN);
supply.SetPaintingStrategy(PaintingStrategy.HIDDEN);
}



It gives me this error on Thinkorswim, how do I fix this ?

Syntax error: An 'else' block expected at 32:1
Syntax error: Semicolon expected at 32:1

 

[Chemmy]

If you're trying to do what I think you are, then I think all you need to do is replace

if (!showZones) then {
demand.SetPaintingStrategy(PaintingStrategy.HIDDEN);
supply.SetPaintingStrategy(PaintingStrategy.HIDDEN);
}

with this:

supply.sethiding(!showzones);
demand.sethiding(!showzones);

Also, as a side note just looking at your code -- you should probably change your definitions of high and low, since those are already defined inside of thinkorswim, maybe calling high "h" and low "l" for instance. Otherwise, defining "high" = highest(high) is inviting your code to overwrite itself.