Help With Strategy Code

[Jank]

Hi I was trying to make a Strategy for buying Forex based on BB and RSI for the minute chart but I'm getting errors from thinkscript, and I don't know how to fix them. Can anyone help me and maybe give me some suggestions on how to improve the strategy?

No such constant: bb.lowerband at 15:17
No such constant: bb.upperband at 16:17
No such constant: bb.lowerband at 15:17
Expected double at 15:5
No such constant: bb.upperband at 16:17
Expected double at 16:5
LOWER not allowed in strategies
Only constants expected here: _inline_referenced_param_bSRP_141_length CL constant function parameter 'length' at 18:16
Only constants expected here: _inline_referenced_param_bSRP_141_length CL constant function parameter 'length' at 18:16
No such constant: bb.lowerband at 15:17
No such constant: bb.upperband at 16:17
No such constant: bb.lowerband at 15:17
Expected double at 15:5
No such constant: bb.upperband at 16:17
Expected double at 16:5
Only constants expected here: _inline_referenced_param_bSRP_141_length CL constant function parameter 'length' at 18:16
Only constants expected here: _inline_referenced_param_bSRP_141_length CL constant function parameter 'length' at 18:16

 

[halcyonguy]

Hi I was trying to make a Strategy for buying Forex based on BB and RSI for the minute chart but I'm getting errors from thinkscript, and I don't know how to fix them. Can anyone help me and maybe give me some suggestions on how to improve the strategy?

No such constant: bb.lowerband at 15:17
No such constant: bb.upperband at 16:17
No such constant: bb.lowerband at 15:17
Expected double at 15:5
No such constant: bb.upperband at 16:17
Expected double at 16:5
LOWER not allowed in strategies
Only constants expected here: _inline_referenced_param_bSRP_141_length CL constant function parameter 'length' at 18:16
Only constants expected here: _inline_referenced_param_bSRP_141_length CL constant function parameter 'length' at 18:16
No such constant: bb.lowerband at 15:17
No such constant: bb.upperband at 16:17
No such constant: bb.lowerband at 15:17
Expected double at 15:5
No such constant: bb.upperband at 16:17
Expected double at 16:5
Only constants expected here: _inline_referenced_param_bSRP_141_length CL constant function parameter 'length' at 18:16
Only constants expected here: _inline_referenced_param_bSRP_141_length CL constant function parameter 'length' at 18:16

errors in strategy,
it lists all the errors at the bottom of code. look at them and go look at the code line.

can't use lower in a strategy
declare lower;

----------------

this is wrong. should have the plot plot name after the () . can't use it on a variable
def bb = BollingerBands(price, length = bbLength, numDevDn = numDevDn, numDevUp = numDevUp);
def lowerBand = bb.lowerBand;
def upperBand = bb.upperBand;

fixed
def bb_lower = BollingerBands(price, length = bbLength, numDevDn = numDevDn, numDevUp = numDevUp).lowerBand;
def bb_upper = BollingerBands(price, length = bbLength, numDevDn = numDevDn, numDevUp = numDevUp).upperBand;

----------------

wrong parameters in RSI(). you didn't specify parameter names , so they have to be in the correct order and quantity. price is 4th parameter, so would need to specify the 3 before price (without names)
def rsiValue = RSI(close, rsiLength);

fixed
def rsiValue = RSI(length = rsiLength, price = close);

go here and learn about the RSI study & parameters
https://tlc.thinkorswim.com/center/reference/Tech-Indicators/studies-library/R-S/RSI

-------------

you are missing addorder to buy on open
addorders are missing parameters and don't have all the names listed


addorders, you have 2 sell to close. i would separate the conditions in first one, so each just has 1 condition. one for target and 1 for stop

AddOrder(OrderType.SELL_TO_CLOSE, sellCondition or stopLossCondition, tickcolor = GetColor(8), arrowcolor = GetColor(8), name = "Sell");


added addorder for buy


----------------

#help_fix_strat2

#https://usethinkscript.com/threads/help-with-strategy-code.18069/
#Help With Strategy Code
#Jank  2/26  #1
#Hi I was trying to make a Strategy for buying Forex based on BB and RSI for the minute chart but I'm getting errors from thinkscript, and I don't know how to fix them. Can anyone help me and maybe give me some suggestions on how to improve the strategy?

# Bollinger Bands and RSI Strategy with Visual Signals

#declare lower;

input bbLength = 20;
input numDevDn = -2.0;
input numDevUp = 2.0;
input rsiLength = 14;
input oversoldThreshold = 40;
input overboughtThreshold = 65;
input stopLossPercent = 5.0;

def price = close;
#def bb = BollingerBands(price, length = bbLength, numDevDn = numDevDn, numDevUp = numDevUp);
#def lowerBand = bb.lowerBand;
#def upperBand = bb.upperBand;

def bb_lower = BollingerBands(price, length = bbLength, numDevDn = numDevDn, numDevUp = numDevUp).lowerBand;
def bb_upper = BollingerBands(price, length = bbLength, numDevDn = numDevDn, numDevUp = numDevUp).upperBand;


#def rsiValue = RSI(close, rsiLength);
def rsiValue = RSI(length = rsiLength, price = close);


def buyCondition = close < bb_lower and rsiValue <= oversoldThreshold;
def sellCondition = close > bb_upper and rsiValue >= overboughtThreshold;

# Buy Signal
plot BuySignal = buyCondition;
BuySignal.SetPaintingStrategy(PaintingStrategy.BOOLEAN_ARROW_UP);
BuySignal.SetDefaultColor(Color.GREEN);

# Sell Signal
plot SellSignal = sellCondition;
SellSignal.SetPaintingStrategy(PaintingStrategy.BOOLEAN_ARROW_DOWN);
SellSignal.SetDefaultColor(Color.RED);

# Stop Loss
def entryPrice = if buyCondition and !buyCondition[1] then close else entryPrice[1];
def stopLossLevel = entryPrice * (1.0 - stopLossPercent / 100);
def stopLossCondition = close <= stopLossLevel;

input tradesize = 1;

# Exit on Stop Loss
#AddOrder(OrderType.SELL_TO_CLOSE, sellCondition or stopLossCondition, tickcolor = GetColor(8), arrowcolor = GetColor(8), name = "Sell");

AddOrder(OrderType.SELL_TO_CLOSE, stopLossCondition, tickcolor = GetColor(8), arrowcolor = GetColor(8), name = "Sell");

# Exit on Target
AddOrder(OrderType.SELL_TO_CLOSE, sellCondition, tickcolor = GetColor(1), arrowcolor = GetColor(1), name = "Sell");

# Set Stop Loss Label
AddLabel(stopLossCondition, "Stop Loss", Color.RED);

# Plot visual signals on the chart
AddChartBubble(buyCondition, low, "Buy", Color.GREEN, no);
AddChartBubble(sellCondition or stopLossCondition, high, "Sell", Color.RED, yes);


addorder(type = OrderType.buy_to_open, condition = buyCondition, price = open[-1], tradesize = tradesize,  tickcolor = Color.green, arrowcolor = Color.green, name = "BUY");

#

 

[Jank]

Heck yeah! I tweaked it a little bit more but it looks pretty good I think! Thank you so much!