So basically, instead of having 2 separate graphs (SMA and MACD) with 2 red or green arrows like I have above in the screenshot, I want to show just the price graph with one buy or sell indicator. And the buy or sell indicator would not show up until BOTH conditions are met. So if you get a Green arrow on the SMA and any number of time periods later you get a green arrow from the MACD then and only then you see a single Buy or Green arrow on the price graph. And likewise in reverse for the Red arrows. Does that make sense?
Join useThinkScript to post your question to a community of 21,000+ developers and traders.
Code:
#Here is the code I used for the above image. There seems to be an issue with the arrows. Sometimes it works and sometimes it doesn't. Any help would be appreciated.
def SMA10 = SimplemovingAvg(close,10);
def MH = MACDHistogram(8,17,9);
plot bullish = if (close > SMA10 and close[1] <= SMA10[1]) and MH >= 0 then 1 else 0;
plot bearish = if (close < SMA10 and close[1] >= SMA10[1]) and MH <= 0 then 1 else 0;
bullish.SetPaintingStrategy(PaintingStrategy.Boolean_Arrow_Up);
bearish.SetPaintingStrategy(PaintingStrategy.Boolean_Arrow_Down);
Bullish.setLineWeight(3);
Bearish.setLineWeight(3);
One way to start debugging your code is to use AddChartBubble.
By adding the following code to your script, it will test for each of your conditions on each and every candle.
When you determine which condition is being returned in error; you can redefine your tests to display each variable in that condition and thus verify your logic. HTH
By adding the following code to your script, it will test for each of your conditions on each and every candle.
When you determine which condition is being returned in error; you can redefine your tests to display each variable in that condition and thus verify your logic. HTH
Code:
def Test1 = if close > SMA10 then 1 else 0;
def Test2 = if close[1] <= SMA10[1] then 1 else 0;;
def Test3 = if MH >= 0 then 1 else 0;;
AddChartBubble(close, close, bullish +" \n" +Test1 +" \n" +Test2 +" \n " +Test3, color.light_gray);
Last edited:
#Below is the code that I have so far. It partially works. The MACD portion worked perfect but when adding the SMA script and I go to plot it, I think it's looking for conditions that are met at the exact same time frame or candle. When the price crosses the SMA at a different time from the MACD no arrow shows up. I want to show an arrow when BOTH conditions are met even if it's not in the same time period. It may not even be looking at the SMA at all and only the MACD. I don't know. Would you be able to look at this code and see where there may be an issue? Thanks for your help.
#See attached screenshot.
#See attached screenshot.
Code:
#SMA
input price = close;
input length = 10;
Def SMA = Average(price,length);
Def SMAup = price >= SMA;
Def SMAdwn = price <= SMA;
#MACD
input fastLength = 8;
input slowLength = 17;
input MACDLength = 9;
input averageType = AverageType.EXPONENTIAL;
def Value = MovingAverage(averageType, close, fastLength) - MovingAverage(averageType, close, slowLength);
def Avg = MovingAverage(averageType, Value, MACDLength);
def Diff = Value - Avg;
def ZeroLine = 0;
def UpSignal = Diff crosses above ZeroLine;
def DwnSignal = Diff crosses below ZeroLine;
plot bullish = UpSignal AND SMAup;
bullish.SetPaintingStrategy(PaintingStrategy.BOOLEAN_ARROW_UP);
bullish.SetDefaultColor(Color.UPTICK);
bullish.SetLineWeight(3);
plot bearish = DwnSignal AND SMAdwn;
bearish.SetPaintingStrategy(PaintingStrategy.BOOLEAN_ARROW_DOWN);
bearish.SetDefaultColor(Color.DOWNTICK);
bearish.SetLineWeight(3);Ichimouko shows 50% retracements, support and resistance, RSI, BB, momentum, elliot wave, and just about everything else if you get to understand it.
I saw someone ask a question about an RSI indicator for the Macd. While both of these indicators are used for momentum, a convolution of the two functions could be used as a stronger indicator. After creating the indicator, I noticed that the Macd-RSI supports that the Macd is changing direction. This indicator will help traders avoid false Macd reversals.
The indicator works like this:
Once the Macd-Rsi has crossed below the overbought (70) zone, one can predict that the current Macd Avg is up for reversal, and will proceed to fall...Same goes for the underbought. If the Macd is approaching a reversal signal, but the Macd-Rsi has not crossed back to the neutral zone from an overbought or oversold position, the Macd reversal is more than likely false (picture 2).
(5 min) As you can see, the indicator does a fine job predicting if a reversal is near.
(5 min) reversal fake-out. The Macd seemed to be approaching a reversal trend. However, the Macd-Rsi did not indicate a reversal.
(1 min chart) The one min chart is a little less accurate which is expected from the Macd on a 1 min scale
The indicator works like this:
Once the Macd-Rsi has crossed below the overbought (70) zone, one can predict that the current Macd Avg is up for reversal, and will proceed to fall...Same goes for the underbought. If the Macd is approaching a reversal signal, but the Macd-Rsi has not crossed back to the neutral zone from an overbought or oversold position, the Macd reversal is more than likely false (picture 2).
(5 min) As you can see, the indicator does a fine job predicting if a reversal is near.
(5 min) reversal fake-out. The Macd seemed to be approaching a reversal trend. However, the Macd-Rsi did not indicate a reversal.
(1 min chart) The one min chart is a little less accurate which is expected from the Macd on a 1 min scale
Where can we find the indicators that you are using?I saw someone ask a question about an RSI indicator for the Macd. While both of these indicators are used for momentum, a convolution of the two functions could be used as a stronger indicator. After creating the indicator, I noticed that the Macd-RSI supports that the Macd is changing direction. This indicator will help traders avoid false Macd reversals.
The indicator works like this:
Once the Macd-Rsi has crossed below the overbought (70) zone, one can predict that the current Macd Avg is up for reversal, and will proceed to fall...Same goes for the underbought. If the Macd is approaching a reversal signal, but the Macd-Rsi has not crossed back to the neutral zone from an overbought or oversold position, the Macd reversal is more than likely false (picture 2).
(5 min) As you can see, the indicator does a fine job predicting if a reversal is near.
(5 min) reversal fake-out. The Macd seemed to be approaching a reversal trend. However, the Macd-Rsi did not indicate a reversal.
(1 min chart) The one min chart is a little less accurate which is expected from the Macd on a 1 min scale
Thanks
Heres my list:
Found in think or swim:
160 Hull Moving Average (blue and yellow line)
12 period HalfTrendIndicator (blue and red line)
50 period SMA (purple)
Personal:
HalfTrendMacd, the code can be found here:
Code:
input Amplitude = 3;
def lowpricei;
def highpricei;
def lowma;
def highma;
def barindex = barNumber();
def nexttrend;
def maxlowprice;
def trend;
def minhighprice;
def up;
def down;
def halftrend;
lowpricei = Lowest(low, Amplitude);
highpricei = Highest(high, Amplitude);
lowma = average(low, Amplitude);
highma = average(high, Amplitude);
if barindex > Amplitude and
nexttrend[1] == 1
{
maxlowprice = Max(lowpricei, maxlowprice[1]);
trend = if highma < maxlowprice[1] and close < low[1]
then 1
else trend[1];
nexttrend = if highma < maxlowprice[1] and close < low[1]
then 0
else nexttrend[1];
minhighprice = if highma < maxlowprice[1] and close < low[1]
then highpricei
else minhighprice[1];
}
else if nexttrend[1] == 0
{
minhighprice = Min(highpricei, minhighprice[1]);
trend = if lowma > minhighprice[1] and close > high[1]
then 0
else trend[1];
nexttrend = if lowma > minhighprice[1] and close > high[1]
then 1
else nexttrend[1];
maxlowprice = if lowma > minhighprice[1] and close > high[1]
then lowpricei
else maxlowprice[1];
}
else
{
maxlowprice = maxlowprice[1];
trend = trend[1];
nexttrend = nexttrend[1];
minhighprice = minhighprice[1];
}
if trend == 0
{
up = if trend[1] <> 0
then down[1]
else Max(maxlowprice[1], up[1]);
down = 0;
}
else if trend[1] <> 1
{
down = up[1];
up = 0;# up[1] este era el error
}
else if trend == 1
{
down = Min(minhighprice, down[1]);
up = up[1];
}
else
{
up =up[1];
down = down[1];
}
if up > 0
{
halftrend = up;
}
else
{
halftrend = down;
}
def UpSignal = if up[1]<1 and up>0 then low else Double.NaN;
def DownSignal = if down[1]<1 and down>0 then high else Double.NaN;
#
# TD Ameritrade IP Company, Inc. (c) 2007-2021
#
declare lower;
input fastLength = 12;
input slowLength = 26;
input MACDLength = 9;
input averageType = AverageType.EXPONENTIAL;
input showBreakoutSignals = no;
plot Value = MovingAverage(averageType, halftrend, fastLength) - MovingAverage(averageType, halftrend, slowLength);
plot Avg = MovingAverage(averageType, Value, MACDLength);
plot Diff = Value - Avg;
plot ZeroLine = 0;
Value.SetDefaultColor(GetColor(1));
Avg.SetDefaultColor(GetColor(8));
Diff.SetDefaultColor(GetColor(5));
Diff.SetPaintingStrategy(PaintingStrategy.HISTOGRAM);
Diff.SetLineWeight(3);
Diff.DefineColor("Positive and Up", Color.GREEN);
Diff.DefineColor("Positive and Down", Color.DARK_GREEN);
Diff.DefineColor("Negative and Down", Color.RED);
Diff.DefineColor("Negative and Up", Color.DARK_RED);
Diff.AssignValueColor(if Diff >= 0 then if Diff > Diff[1] then Diff.color("Positive and Up") else Diff.color("Positive and Down") else if Diff < Diff[1] then Diff.color("Negative and Down") else Diff.color("Negative and Up"));
ZeroLine.SetDefaultColor(GetColor(0));Thanks .
Is the macd rsi your own personal indicator or is that part of TOS I.e the very last lower study.
Its my own study. Here ya go
Code:
declare lower;
input fastLength = 12;
input slowLength = 26;
input MACDLength = 9;
input averageTypeMacd = AverageType.EXPONENTIAL;
input averageType = AverageType.WILDERS;
input showBreakoutSignals = no;
input length = 14;
input over_Bought = 70;
input over_Sold = 30;
#########Macd
def Value = MovingAverage(averageTypeMacd, close, fastLength) - MovingAverage(averageTypeMacd, close, slowLength);
def Avg = MovingAverage(averageTypeMacd, Value, MACDLength);
def price = avg;
###########RSI
def NetChgAvg = MovingAverage(averageType, price - price[1], length);
def TotChgAvg = MovingAverage(averageType, AbsValue(price - price[1]), length);
def ChgRatio = if TotChgAvg != 0 then NetChgAvg / TotChgAvg else 0;
plot RSI = 50 * (ChgRatio + 1);
plot OverSold = over_Sold;
plot OverBought = over_Bought;
plot UpSignal = if RSI crosses above OverSold then OverSold else Double.NaN;
plot DownSignal = if RSI crosses below OverBought then OverBought else Double.NaN;
UpSignal.SetHiding(!showBreakoutSignals);
DownSignal.SetHiding(!showBreakoutSignals);
RSI.DefineColor("OverBought", GetColor(5));
RSI.DefineColor("Normal", GetColor(7));
RSI.DefineColor("OverSold", GetColor(1));
RSI.AssignValueColor(if RSI > over_Bought then RSI.color("OverBought") else if RSI < over_Sold then RSI.color("OverSold") else RSI.color("Normal"));
OverSold.SetDefaultColor(GetColor(8));
OverBought.SetDefaultColor(GetColor(8));
UpSignal.SetDefaultColor(Color.UPTICK);
UpSignal.SetPaintingStrategy(PaintingStrategy.ARROW_UP);
DownSignal.SetDefaultColor(Color.DOWNTICK);
DownSignal.SetPaintingStrategy(PaintingStrategy.ARROW_DOWN);
Joseph Patrick 18
Active member
Hi, is there anyway to adjust the Half Trend MACD? For some reason (I have expansion area 25 bars to the right) the MACD_RSI stops were it should (at the current price bar) but the HT_MACD extends much further to right. Thanks in advance.
@Joseph Patrick 18 This may be a result of your bar type. I looked at the same ticker at the same time and I am not experiencing this problem. This script is a real time script so it does not predict the future. Make sure you didnt accidently add a displacement to the code.
Try changing your chart type to candle and see if that fixes the problem.
Try changing your chart type to candle and see if that fixes the problem.
It does the same thing for me as well. My chart, I tried changing to candle, candle trend, line and it still shows the HT_MACD further to the right.
Joseph Patrick 18
Active member
Ok thanks I appreciate the response! Just wanted to make sure. Thank you.
Joseph Patrick 18
Active member
Hi thanks for the response appreciate it! I tried diff bar types and attached the script...
Thanks in advance.
#https://usethinkscript.com/threads/rsi-macd-confluence-indicator-for-thinkorswim.505/page-2
Code:
input Amplitude = 3;
def lowpricei;
def highpricei;
def lowma;
def highma;
def barindex = barNumber();
def nexttrend;
def maxlowprice;
def trend;
def minhighprice;
def up;
def down;
def halftrend;
lowpricei = Lowest(low, Amplitude);
highpricei = Highest(high, Amplitude);
lowma = average(low, Amplitude);
highma = average(high, Amplitude);
if barindex > Amplitude and
nexttrend[1] == 1
{
maxlowprice = Max(lowpricei, maxlowprice[1]);
trend = if highma < maxlowprice[1] and close < low[1]
then 1
else trend[1];
nexttrend = if highma < maxlowprice[1] and close < low[1]
then 0
else nexttrend[1];
minhighprice = if highma < maxlowprice[1] and close < low[1]
then highpricei
else minhighprice[1];
}
else if nexttrend[1] == 0
{
minhighprice = Min(highpricei, minhighprice[1]);
trend = if lowma > minhighprice[1] and close > high[1]
then 0
else trend[1];
nexttrend = if lowma > minhighprice[1] and close > high[1]
then 1
else nexttrend[1];
maxlowprice = if lowma > minhighprice[1] and close > high[1]
then lowpricei
else maxlowprice[1];
}
else
{
maxlowprice = maxlowprice[1];
trend = trend[1];
nexttrend = nexttrend[1];
minhighprice = minhighprice[1];
}
if trend == 0
{
up = if trend[1] <> 0
then down[1]
else Max(maxlowprice[1], up[1]);
down = 0;
}
else if trend[1] <> 1
{
down = up[1];
up = 0;# up[1] este era el error
}
else if trend == 1
{
down = Min(minhighprice, down[1]);
up = up[1];
}
else
{
up =up[1];
down = down[1];
}
if up > 0
{
halftrend = up;
}
else
{
halftrend = down;
}
def UpSignal = if up[1]<1 and up>0 then low else Double.NaN;
def DownSignal = if down[1]<1 and down>0 then high else Double.NaN;
#
# TD Ameritrade IP Company, Inc. (c) 2007-2021
#
declare lower;
input fastLength = 12;
input slowLength = 26;
input MACDLength = 9;
input averageType = AverageType.EXPONENTIAL;
input showBreakoutSignals = no;
plot Value = MovingAverage(averageType, halftrend, fastLength) - MovingAverage(averageType, halftrend, slowLength);
plot Avg = MovingAverage(averageType, Value, MACDLength);
plot Diff = Value - Avg;
plot ZeroLine = 0;
Value.SetDefaultColor(GetColor(1));
Avg.SetDefaultColor(GetColor(8));
Diff.SetDefaultColor(GetColor(5));
Diff.SetPaintingStrategy(PaintingStrategy.HISTOGRAM);
Diff.SetLineWeight(3);
Diff.DefineColor("Positive and Up", Color.GREEN);
Diff.DefineColor("Positive and Down", Color.DARK_GREEN);
Diff.DefineColor("Negative and Down", Color.RED);
Diff.DefineColor("Negative and Up", Color.DARK_RED);
Diff.AssignValueColor(if Diff >= 0 then if Diff > Diff[1] then Diff.color("Positive and Up") else Diff.color("Positive and Down") else if Diff < Diff[1] then Diff.color("Negative and Down") else Diff.color("Negative and Up"));
ZeroLine.SetDefaultColor(GetColor(0));Im not sure why this is happening. I copied and pasted your code and im not experiencing that issue.
Maybe try importing it from this link: https://tos.mx/XNq7I6u
Joseph Patrick 18
Active member
Ok thanks I just tried it and the same result with 10 bars extension to the right. It's okay don't worry about it probably one of my settings is interfering with it somehow but thanks for getting back to me.Im not sure why this is happening. I copied and pasted your code and im not experiencing that issue.
Maybe try importing it from this link: https://tos.mx/XNq7I6u
Im also trying to figure out why its doing that.. If you do find a solution, please let me know and I shall do the same
Are y'all noticing the last candle macd value changing. For instance, the indicator is 10 bars in the present, is the -10th bar value changing in real time? It looks like the closing values are still correct so this indicator can still be used with the error, you just have to wait for the bar to close.
It also looks like the future values are being predicted very accurately.... so now Im questioning how I can get my set up to display the same as y'all
Last edited:
Joseph Patrick 18
Active member
Hi,
Here is my Grid shared with my settings...maybe one of my settings is off... lemme know if you can't access and I'll resend. Thanks for taking the time!
http://tos.mx/ZEvOanB
Similar threads
-
Super 6x: RSI, MACD, Stoch, Loxxer, CCI, & Velocity [Loxx] for ThinkOrSwim- Started by samer800
- Replies: 52
-
Repaints RSI, OBV, MACD, STOCH, CCI, or MFI Divergence For ThinkOrSwim
- Started by samer800
- Replies: 30
-
-
-
Similar threads
-
Super 6x: RSI, MACD, Stoch, Loxxer, CCI, & Velocity [Loxx] for ThinkOrSwim
- Started by samer800
- Replies: 52
-
Repaints RSI, OBV, MACD, STOCH, CCI, or MFI Divergence For ThinkOrSwim
- Started by samer800
- Replies: 30
-
-
-
Similar threads
-
Super 6x: RSI, MACD, Stoch, Loxxer, CCI, & Velocity [Loxx] for ThinkOrSwim
- Started by samer800
- Replies: 52
-
Repaints RSI, OBV, MACD, STOCH, CCI, or MFI Divergence For ThinkOrSwim
- Started by samer800
- Replies: 30
-
-
-
The Market Trading Game Changer
Join 2,500+ subscribers inside the useThinkScript VIP Membership Club
- Exclusive indicators
- Proven strategies & setups
- Private Discord community
- ‘Buy The Dip’ signal alerts
- Exclusive members-only content
- Add-ons and resources
- 1 full year of unlimited support
Frequently Asked Questions
What is useThinkScript?
useThinkScript is the #1 community of stock market investors using indicators and other tools to power their trading strategies. Traders of all skill levels use our forums to learn about scripting and indicators, help each other, and discover new ways to gain an edge in the markets.
How do I get started?
We get it. Our forum can be intimidating, if not overwhelming. With thousands of topics, tens of thousands of posts, our community has created an incredibly deep knowledge base for stock traders. No one can ever exhaust every resource provided on our site.
If you are new, or just looking for guidance, here are some helpful links to get you started.
- The most viewed thread:
https://usethinkscript.com/threads/repainting-trend-reversal-for-thinkorswim.183/ - Our most popular indicator:
https://usethinkscript.com/threads/buy-the-dip-indicator-for-thinkorswim.3553/ - Answers to frequently asked questions:
https://usethinkscript.com/threads/answers-to-commonly-asked-questions.6006/
What are the benefits of VIP Membership?
VIP members get exclusive access to these proven and tested premium indicators: Buy the Dip, Advanced Market Moves 2.0, Take Profit, and Volatility Trading Range. In addition, VIP members get access to over 50 VIP-only custom indicators, add-ons, and strategies, private VIP-only forums, private Discord channel to discuss trades and strategies in real-time, customer support, trade alerts, and much more. Learn all about VIP membership here.
How can I access the premium indicators?
To access the premium indicators, which are plug and play ready, sign up for VIP membership here.