Turn off AssignPriceColor?

[keithmj]

This seems like it should be easy, but I'm stuck. I simply want to be able to turn on or off the AssignPriceColor function with a user option.

I have a user option:
input show_price_bar_colors = yes;

later in the script I have the AssignPriceColor function. The below code somewhat worked, but it seems like it should be easier than this. I can turn off all the colors assigned by the if statements, but that last "else" that applies to all other conditions ends up painting all the bars.

AssignPriceColor(if (big_vol_price_up and show_price_bar_colors) then GlobalColor("big_vol_price_up") else if (big_vol_price_down and show_price_bar_colors) then GlobalColor("big_vol_price_down") else if (little_vol_price_up and show_price_bar_colors) then GlobalColor("little_vol_price_up") else if (little_vol_price_down and show_price_bar_colors) then GlobalColor("little_vol_price_down") else GlobalColor("normal_vol_price"))

How can I just toggle the AssignPriceColor function on and off so I either get the custom settings or the default chart settings?

Thanks!

 

[keithmj]

This seems like it should be easy, but I'm stuck. I simply want to be able to turn on or off the AssignPriceColor function with a user option.

I have a user option:
input show_price_bar_colors = yes;

later in the script I have the AssignPriceColor function. The below code somewhat worked, but it seems like it should be easier than this. I can turn off all the colors assigned by the if statements, but that last "else" that applies to all other conditions ends up painting all the bars.

AssignPriceColor(if (big_vol_price_up and show_price_bar_colors) then GlobalColor("big_vol_price_up") else if (big_vol_price_down and show_price_bar_colors) then GlobalColor("big_vol_price_down") else if (little_vol_price_up and show_price_bar_colors) then GlobalColor("little_vol_price_up") else if (little_vol_price_down and show_price_bar_colors) then GlobalColor("little_vol_price_down") else GlobalColor("normal_vol_price"))

How can I just toggle the AssignPriceColor function on and off so I either get the custom settings or the default chart settings?

Thanks!

I think I just figured it out... DUH

I can put each condition as a separate AssignPriceColor function instead of the big stupid "if" statement. Like this:

AssignPriceColor(if (big_vol_price_up and show_price_bar_color) then Global("big_vol_price_up) else Color.CURRENT;

AssignPriceColor(if (big_vol_price_down and show_price_bar_color) then Global("big_vol_price_doen) else Color.CURRENT;

etc, etc

 

[halcyonguy]

This seems like it should be easy, but I'm stuck. I simply want to be able to turn on or off the AssignPriceColor function with a user option.

I have a user option:
input show_price_bar_colors = yes;

later in the script I have the AssignPriceColor function. The below code somewhat worked, but it seems like it should be easier than this. I can turn off all the colors assigned by the if statements, but that last "else" that applies to all other conditions ends up painting all the bars.

AssignPriceColor(if (big_vol_price_up and show_price_bar_colors) then GlobalColor("big_vol_price_up") else if (big_vol_price_down and show_price_bar_colors) then GlobalColor("big_vol_price_down") else if (little_vol_price_up and show_price_bar_colors) then GlobalColor("little_vol_price_up") else if (little_vol_price_down and show_price_bar_colors) then GlobalColor("little_vol_price_down") else GlobalColor("normal_vol_price"))

How can I just toggle the AssignPriceColor function on and off so I either get the custom settings or the default chart settings?

Thanks!

can simplify the original code by processing the inverse of the enable signal first, by adding a ! before it.
then it doesn't have to be 'and'ed' to every condition.

!show_price_bar_colors
that is read as,
not show_price_bar_colors , or

in other words, if it is false, then invert to be true and use default colors.

AssignPriceColor(
if !show_price_bar_colors then color.current
else if big_vol_price_up then GlobalColor("big_vol_price_up")
else if big_vol_price_down then GlobalColor("big_vol_price_down")
else if little_vol_price_up and then GlobalColor("little_vol_price_up")
else if little_vol_price_down then GlobalColor("little_vol_price_down")
else GlobalColor("normal_vol_price")
);

i think it is better to use just one instance of AssignPriceColor() in a study, that contains all of the conditions.

i am basing that on what i have seen when multiple loaded studies have that function in them.
if there are 2 studies loaded , that each have AssignPriceColor(), then the candle coloring will be wrong and unpredictable.

similar with assignbackgroundcolor().

similarly, if 2 strategies are loaded, the strategy arrows and lines will be wrong.

 

[keithmj]

I didn't know that about multiple instances of the function, and I do have 2 studies loaded with similar functions. I guess I'll have to re-think my last post. Thanks for the heads up!