review my code for Support and Resistance for ThinkorSwim?

[petergluis]

Could you please check my code for Support and Resistance for ThinkorSwim? I converted Support and Resistance for ThinkorSwim. But it doesn't show in a right way.

https://www.tradingview.com/script/JWdq2Bni-RS-Support-and-Resistance-V0/

def window1 = 8;
def window2 = 21;
def condition1 = high >= highest(high, window1);
def top1 = if condition1 then high else 0;
def condition2 =low <= lowest(low, window1);
def bot1 = if condition2 then low else 0;
def condition3 = high >= highest(high, window2);
def top2 = if condition3 then high else 0;
def condition4 = low <= lowest(low, window2);
def bot2 = if condition4 then low else 0;

plot t1 = top1;
plot b1 = bot1;
plot t2 = top2;
plot b2 = bot2;

 

[halcyonguy]

Could you please check my code for Support and Resistance for ThinkorSwim? I converted Support and Resistance for ThinkorSwim. But it doesn't show in a right way.

https://www.tradingview.com/script/JWdq2Bni-RS-Support-and-Resistance-V0/

def window1 = 8;
def window2 = 21;
def condition1 = high >= highest(high, window1);
def top1 = if condition1 then high else 0;
def condition2 =low <= lowest(low, window1);
def bot1 = if condition2 then low else 0;
def condition3 = high >= highest(high, window2);
def top2 = if condition3 then high else 0;
def condition4 = low <= lowest(low, window2);
def bot2 = if condition4 then low else 0;

plot t1 = top1;
plot b1 = bot1;
plot t2 = top2;
plot b2 = bot2;

do you see spikes on 1 bar?
you are finding a condition on 1 bar, but then going to 0 for the other bars.
you don't have anything to retain a value.

chg this,
def top1 = if condition1 then high else 0;

to this,
def top1 = if condition1 then high else top1[1];

 

[petergluis]

do you see spikes on 1 bar?
you are finding a condition on 1 bar, but then going to 0 for the other bars.
you don't have anything to retain a value.

chg this,
def top1 = if condition1 then high else 0;

to this,
def top1 = if condition1 then high else top1[1];

Thank you very much for your help. It is working now after I follow your suggestion.

https://imgur.com/qhYsTCz

def window1 = 8;
def window2 = 21;
def condition1 = high >= highest(high, window1);
def top1 = if condition1 then high else top1[1];
def condition2 =low <= lowest(low, window1);
def bot1 = if condition2 then low else bot1[1];
def condition3 = high >= highest(high, window2);
def top2 = if condition3 then high else top2[1];
def condition4 = low <= lowest(low, window2);
def bot2 = if condition4 then low else bot2[1];
plot t1 = top1;
plot b1 = bot1;
plot t2 = top2;
plot b2 = bot2;
Addcloud (t1, t2, color.yellow, color.pink);
Addcloud (b1, b2, color.light_green, color.cyan);