What am I missing? Keep getting an error message. The code looks correct to me but I am missing something. Any assistance would be greatly appreciated. Trying to measure the body of candles in a given time period vs the wicks.
Ruby:
def bodymax = Max(open, close);
def bodymin = Min(open, close);
def rng = BodyHeight();
plot rng1 = rng;
input aggregationPeriod = AggregationPeriod.DAY;
input length = 1;
input displace = -1;
input showOnlyLastPeriod = no;
plot DailyHigh = bodymax;
plot DailyLow = bodymin;
plot Mid;
if showOnlyLastPeriod and !IsNaN(close(period = aggregationPeriod)[-1]) {
DailyHigh = Double.NaN;
DailyLow = Double.NaN;
} else {
DailyHigh = Highest(high(period = aggregationPeriod)[-displace], length);
DailyLow = Lowest(low(period = aggregationPeriod)[-displace], length);
}
Mid = (DailyHigh + DailyLow) / 2;
DailyHigh.SetDefaultColor(GetColor(4));
DailyHigh.SetPaintingStrategy(PaintingStrategy.HORIZONTAL);
DailyLow.SetDefaultColor(GetColor(4));
DailyLow.SetPaintingStrategy(PaintingStrategy.HORIZONTAL);
Mid.SetDefaultColor(GetColor(4));
Mid.SetPaintingStrategy(PaintingStrategy.HORIZONTAL
the last code line is missing a ) and ;
Mid.SetPaintingStrategy(PaintingStrategy.HORIZONTAL
should be this,
Mid.SetPaintingStrategy(PaintingStrategy.HORIZONTAL);
after that is fixed, then more errors show up.
this is an annoying quirk of thinkscript, that not all the errors show up at first. this leads people to think they just have 1 error to fix, when they could have 10.
you are trying to use variables within if then's , but you assigned values to them before the if then.
these 2 lines,
plot DailyHigh = bodymax;
plot DailyLow = bodymin;
should be,
plot DailyHigh;
plot DailyLow;
now the errors are gone, but is the code right ?
close up of candles
lines are highest and lowest , from yesterday
but there is also a line near 0
that is exists because of this
plot rng1 = rng;
don't need that, so disable that line with a #
# plot rng1 = rng;
when i am debugging, i tend to disable code lines, instead of deleting them. that way i can copy it , change it a little, then see a progression of what i tried. when it is all working, then go clean it up.
----------------------
i am not sure what you want to see?
your words don't match the code.
you say wicks and body, but the code is only plotting wicks (high and low)
so it looks like the default values plot lines at the previous 1 day highest and lowest levels, and a mid line.
is that what you want ?
what do you want to see on the chart? (if you can answer this, it is easier to find the answer)
will you ever want the highest number from several days?
if not then you don't need highest( , length)
you could replace that if then with this,
input aggregationPeriod = AggregationPeriod.DAY;
input offset = 1;
plot zhigh = high(period = aggregationPeriod)[offset];
plot zlow = low(period = aggregationPeriod)[offset];
the -displace within that highest() is a little confusing. why have a negative value, and a negative on the variable?
input displace = -1;
2 negatives make a postive, so just leave it off both.
i don't know what this means, so i'm going to stop.
Trying to measure the body of candles in a given time period vs the wicks.
could create a ratio % of body to wicks with this,
def x = 100*bodyheight()/(high-low);
would need to add agg to all values if desired.
