KDJ from pinescript to thinkscript

[Chaomane]

The Converted KDJ Indicator for ThinkOrSwim can be found: https://usethinkscript.com/threads/kdj-indicator-for-thinkorswim.9501/ Fill free to continue discussion there. This thead is locked.

​

I'd love if someone with more experience could convert this script for me, I'd even be willing to pay a bit. KDJ indicator.

study("KDJ Indicator")
// KDJ Indicator, Rev 03
//
// Rewrite for Tradingview "Pine Script" by Kocurekc, April 2014
// https://getsatisfaction.com/tradingview/
// https://www.tradingview.com/u/kocurekc/
// Code is provided as public domain, no warranty
 
lenL = input(title="Lookback Period, Long", type=integer, defval=14, minval=2)
lenS = input(title="Lookback Period, Short", type=integer, defval=5, minval=2)
bE = input(title="Use EMA?", type=bool, defval=true)
bJ = input(title="Smooth the %J?", type=bool, defval=false)
lenJ = input(title="%J Smoothing", type=integer, defval=5, minval=1)
 
s = stoch(close, high, low, lenL)
pK = bE ? ema(s,5) : sma(s,5)
pD = bE ? ema(pK, lenS) : sma(pK, lenS)
pJ = (3 * pD) - (2 * pK)
 
plot(pK, color=blue)
plot(pD, color=red)
plot(bJ ? sma(pJ,lenJ) : pJ, color=green)

 

[hanimusa]

Thanks a lot @BenTen

 

[FOTM_8888]

hi diazlaz, thank you for sharing this very nice scripts, can i ask you for a favor, do you think is possible to add a buy and sell arrow on the top of the chart, as soon the candle changes color from red tu green then a green arrow appear on the bottom of the candles and viceversas. thank yo and advance.

 

[MerryDay]

@FOTM_8888
You can find the arrow definitions in Post#18 of this thread
You and I just had a discussion on how to move the arrows to the upper chart.
To post a lower indicator in an upper chart with just the arrows.
When you applied those instructions to this indicator, did you run into problems?
What error message are you getting?

 

[FOTM_8888]

I am getting error: can not call setdefaultcolor on ppj at 43:1 and two more error. I'm sorry.

 

[MerryDay]

@FOTM_8888 No problem at all.

The plot command is used to PRINT stuff on a chart. When we change 'plot' to 'def'. We are telling it to NOT print those lines because we only want arrows. BUT along with the plot command, there are other formatting commands for the ppJ, ppD, ppK which need to be removed. Delete the "SetDefaultColor" lines for each of those variables. Seeing as you are not printing them, they don't need color.

If you edit other indicators in the future watch for: SetLineWeight and PrintingStrategy as other lines that would need to be removed.

 

[FOTM_8888]

Thank you @MerryDay, I did it but is not plotting arrow.

 

[MerryDay]

Congratulations!

As you didn't provide your modified script, I can't know for sure where the problem is. I have to guess.
Most likely your plot command for the arrows have not been changed to point to a place on your upper chart.

#your code
plot ppJ_crossUP = if ppJ crosses above OverSold then OverSold else double.NaN ;
plot ppJ_crossDN = if ppJ crosses below OverBought then OverBought else double.NaN ;

You don't have an Oversold or Overbought on the upper chart so no arrow.

You can do pretty formatting like is shown in the example you are following or just change it to point to the low and high parts of the candle
like this:

#changed to this:
plot ppJ_crossUP = if ppJ crosses above OverSold then low else double.NaN ;
plot ppJ_crossDN = if ppJ crosses below OverBought then high else double.NaN ;

Do you see?

 

[hanimusa]

I still have the same problem doesn't give me any chooses for scan I think the code need to add something more to allow for the scan. Also it is not working on mobile application. Please can you make it available for mobile application as well

 

[MerryDay]

@hanimusa Did you follow the directions in Post#18 of this thread? Once you have done that, you should be able to scan for the up and down arrows.

Sorry, I have no experience w/ the mobile application.

 

[FOTM_8888]

thank you some much merryday, it is works

 

[DMacTrades]

Hi @wtf_dude . First off, I want to thank you for this code. I use very few indicators, however this is one that I have made part of my go-to setup. Thank you! I note that in the code it looks like you have added functionality for "buy" / "sell" signals (up arrows / down arrows), but that they are disabled. Would you be willing to post a version that includes those signals? As always, I am happy to pay for work done. Keep well.

 

[Amzning]

Is this what you are looking for:

# To Add CrossOver Signals to KDJ indicator
# paste the following code into the end of your study:

plot ppJ_crossUP = if ppJ crosses above OverSold then OverSold else double.NaN ;
plot ppJ_crossDN = if ppJ crosses below OverBought then OverBought else double.NaN ;

ppJ_crossUP.SetPaintingStrategy(PaintingStrategy.ARROW_up);
ppJ_crossUP.SetLineWeight(2);
ppJ_crossUP.SetDefaultColor(color.green) ;
ppJ_crossDN.SetPaintingStrategy(PaintingStrategy.ARROW_DOWN);
ppJ_crossDN.SetLineWeight(2);
ppJ_crossDN.SetDefaultColor(color.red) ;

Hi, does anyone know if a Chime/Bell can be added to this indicator, when the line is above 100 & when the line is under 0? Not sure if this is possible or not, but thought I'd ask as someone just recently shared this indicator through a discord channel. Here's a link to their TOS Script: http://tos.mx/3fN3VQb

 

[Amzning]

@MerryDay I think I'll just stick to the Updated script with the arrows that you've added. It seems to work much smoother without the Bell/Chimes as those chimes are triggering based on EMA crossings & I don't believe that this is what the KDJ Indicator was created for

 

[MerryDay]

@MerryDay I think I'll just stick to the Updated script with the arrows that you've added. It seems to work much smoother without the Bell/Chimes as those chimes are triggering based on EMA crossings & I don't believe that this is what the KDJ Indicator was created for

Ahhhh... I see. You got some upper chart script from somewhere and then tried to add your lower chart plots to it.
Yeah, that was never going to work.

If you want alerts, you need to use the original script and then add:

# To Add CrossOver Alerts to KDJ indicator
# paste the following code into the end of your study:

Alert(ppJ_crossUP , "ppJ_crossUP ", Alert.Bar, Sound.Chimes);
Alert(ppJ_crossDN  , "ppJ_crossDN ", Alert.Bar, Sound.bell);

 

[Amzning]

Ahhhh... I see. You got some upper chart script from somewhere and then tried to add your lower chart plots to it.
Yeah, that was never going to work.

If you want alerts, you need to use the original script and then add:

# To Add CrossOver Alerts to KDJ indicator
# paste the following code into the end of your study:

Alert(ppJ_crossUP , "ppJ_crossUP ", Alert.Bar, Sound.Chimes);
Alert(ppJ_crossDN  , "ppJ_crossDN ", Alert.Bar, Sound.bell);

Thanks @MerryDay....this has definitely corrected the Script & I'm back testing it now to see if the alerts are triggered correctly which I expect it will be. Thanks again as you've been #AWESOME