candle crossing upper / lower ATR bands

[I am Investing]

Can someone help me? I want to show the candle closing beyond the defined upper and lower bounds. Why does the script show an arrow on every bar in the chart? And how can I show the arrow on the chart instead of below it? I have attached the script and screen. Thank you.

input length = 14;
input averageType = AverageType.WILDERS;
input BasePeriod = AggregationPeriod.WEEK;
input ATRMultiplier = 2.0;

def pATR = MovingAverage(averageType, TrueRange(high(period = BasePeriod)[1], close(period = BasePeriod)[1], low(period = BasePeriod)[1]), length);
def tATR = MovingAverage(averageType, TrueRange(high(period = BasePeriod)[1], close(period = BasePeriod)[1], low(period = BasePeriod)[1]), length);
def ATR = max(pATR,tATR);

def thisPeriodHigh = high(period = BasePeriod)[0];
def thisPeriodLow = low(period = BasePeriod)[0];
def thisPeriodRange = thisPeriodHigh - thisPeriodLow;
def lastPeriodClose = close(period = BasePeriod)[1];

def hatr = lastPeriodClose + ATR * ATRMultiplier;
def hdtr = thisPeriodLow + ATR * ATRMultiplier;
plot uBound = if hatr < hdtr then hatr else hdtr;
uBound.SetDefaultColor(color = Color.RED);

def latr = lastPeriodClose - ATR * ATRMultiplier;
def ldtr = thisPeriodHigh - ATR * ATRMultiplier;
plot lBound = if latr > ldtr then latr else ldtr;
lBound.SetDefaultColor(color = Color.GREEN);

plot isOver = close(period = BasePeriod) > uBound;
isOver.setpaintingStrategy(paintingStrategy.ARROW_UP);
isOver.setdefaultColor(color.CYAN);
isOver.setlineWeight(1);
plot isUnder = close(period = BasePeriod) < lBound;
isUnder.setpaintingStrategy(paintingStrategy.ARROW_DOWN);
isUnder.setdefaultColor(color.CYAN);
isUnder.setlineWeight(1);

 

[rad14733]

I didn't test this corrected code but it should work... I found two issues... First, I replaced < and > with crosses below and crosses above so you only get one boolean trigger instead of multiple... Second, we use BOOLEAN_ARROW_UP/DOWN for boolean decisions like crosses above/below... No other logic was checked...

Let us know if this works...

input length = 14;
input averageType = AverageType.WILDERS;
input BasePeriod = AggregationPeriod.WEEK;
input ATRMultiplier = 2.0;

def pATR = MovingAverage(averageType, TrueRange(high(period = BasePeriod)[1], close(period = BasePeriod)[1], low(period = BasePeriod)[1]), length);
def tATR = MovingAverage(averageType, TrueRange(high(period = BasePeriod)[1], close(period = BasePeriod)[1], low(period = BasePeriod)[1]), length);
def ATR = max(pATR,tATR);

def thisPeriodHigh = high(period = BasePeriod)[0];
def thisPeriodLow = low(period = BasePeriod)[0];
def thisPeriodRange = thisPeriodHigh - thisPeriodLow;
def lastPeriodClose = close(period = BasePeriod)[1];

def hatr = lastPeriodClose + ATR * ATRMultiplier;
def hdtr = thisPeriodLow + ATR * ATRMultiplier;
plot uBound = if hatr < hdtr then hatr else hdtr;
uBound.SetDefaultColor(color = Color.RED);

def latr = lastPeriodClose - ATR * ATRMultiplier;
def ldtr = thisPeriodHigh - ATR * ATRMultiplier;
plot lBound = if latr > ldtr then latr else ldtr;
lBound.SetDefaultColor(color = Color.GREEN);

plot isOver = close(period = BasePeriod) crosses above uBound;
isOver.setpaintingStrategy(paintingStrategy.BOOLEAN_ARROW_UP);
isOver.setdefaultColor(color.CYAN);
isOver.setlineWeight(1);

plot isUnder = close(period = BasePeriod) crosses below lBound;
isUnder.setpaintingStrategy(paintingStrategy.BOOLEAN_ARROW_DOWN);
isUnder.setdefaultColor(color.CYAN);
isUnder.setlineWeight(1);

 

[I am Investing]

I believe I can count the number of crossovers above and below using a counter.

I use 'def' to declare the counter, but I wonder what would happen if I used 'rec' instead. The outcome appears to be the same.

My code is provided below:

input length = 14;
input averageType = AverageType.WILDERS;
input BasePeriod = AggregationPeriod.WEEK;
input ATRMultiplier = 1.7;

def pATR = MovingAverage(averageType, TrueRange(high(period = BasePeriod)[1], close(period = BasePeriod)[1], low(period = BasePeriod)[1]), length);
def tATR = MovingAverage(averageType, TrueRange(high(period = BasePeriod)[1], close(period = BasePeriod)[1], low(period = BasePeriod)[1]), length);
def ATR = max(pATR,tATR);

def thisPeriodHigh = high(period = BasePeriod)[0];
def thisPeriodLow = low(period = BasePeriod)[0];
def thisPeriodRange = thisPeriodHigh - thisPeriodLow;
def lastPeriodClose = close(period = BasePeriod)[1];

def hatr = lastPeriodClose + ATR * ATRMultiplier;
def hdtr = thisPeriodLow + ATR * ATRMultiplier;
plot uBound = if hatr < hdtr then hatr else hdtr;
uBound.SetDefaultColor(color = Color.RED);

def latr = lastPeriodClose - ATR * ATRMultiplier;
def ldtr = thisPeriodHigh - ATR * ATRMultiplier;
plot lBound = if latr > ldtr then latr else ldtr;
lBound.SetDefaultColor(color = Color.GREEN);

plot isOver = close(period = BasePeriod) crosses above uBound;
isOver.setpaintingStrategy(paintingStrategy.BOOLEAN_ARROW_UP);
isOver.setdefaultColor(color.CYAN);
isOver.setlineWeight(1);
def aboveCount = if IsNaN(aboveCount[1]) then 0
else if isOver then aboveCount[1] + 1 else aboveCount[1];

plot isUnder = close(period = BasePeriod) crosses below lBound;
isUnder.setpaintingStrategy(paintingStrategy.BOOLEAN_ARROW_DOWN);
isUnder.setdefaultColor(color.CYAN);
isUnder.setlineWeight(1);
def belowCount = if IsNaN(belowCount[1]) then 0
else if isUnder then belowCount[1] + 1 else belowCount[1];

def totalCount = aboveCount + belowCount;

AddLabel(visible = yes, text = "No Of Bars: " + BarNumber() + ", Close Above = " + aboveCount + ", Close Below = " + belowCount + " , Total = " + totalCount, color = Color.LIGHT_GRAY);

Addressed a bug.

I checked if it was Over and Under before the NaN.

I have included the updated code below.

input length = 14;
input averageType = AverageType.WILDERS;
input BasePeriod = AggregationPeriod.WEEK;
input ATRMultiplier = 1.7;

def pATR = MovingAverage(averageType, TrueRange(high(period = BasePeriod)[1], close(period = BasePeriod)[1], low(period = BasePeriod)[1]), length);
def tATR = MovingAverage(averageType, TrueRange(high(period = BasePeriod)[1], close(period = BasePeriod)[1], low(period = BasePeriod)[1]), length);
def ATR = max(pATR,tATR);

def thisPeriodHigh = high(period = BasePeriod)[0];
def thisPeriodLow = low(period = BasePeriod)[0];
def thisPeriodRange = thisPeriodHigh - thisPeriodLow;
def lastPeriodClose = close(period = BasePeriod)[1];

def hatr = lastPeriodClose + ATR * ATRMultiplier;
def hdtr = thisPeriodLow + ATR * ATRMultiplier;
plot uBound = if hatr < hdtr then hatr else hdtr;
uBound.SetDefaultColor(color = Color.RED);

def latr = lastPeriodClose - ATR * ATRMultiplier;
def ldtr = thisPeriodHigh - ATR * ATRMultiplier;
plot lBound = if latr > ldtr then latr else ldtr;
lBound.SetDefaultColor(color = Color.GREEN);

plot isOver = close(period = BasePeriod) crosses above uBound;
isOver.setpaintingStrategy(paintingStrategy.BOOLEAN_ARROW_UP);
isOver.setdefaultColor(color.GREEN);
isOver.setlineWeight(5);
#def aboveCount = if IsNaN(aboveCount[1]) then 0
#else if isOver then aboveCount[1] + 1 else aboveCount[1];
def aboveCount;
if isOver then {
aboveCount = if IsNaN(aboveCount[1]) then 1 else aboveCount[1] + 1;
} else {
aboveCount = aboveCount[1];
};

plot isUnder = close(period = BasePeriod) crosses below lBound;
isUnder.setpaintingStrategy(paintingStrategy.BOOLEAN_ARROW_DOWN);
isUnder.setdefaultColor(color.RED);
isUnder.setlineWeight(5);
def belowCount;
if isUnder then {
belowCount = if IsNaN(belowCount[1]) then 1 else belowCount[1] + 1;
} else {
belowCount = belowCount[1];
};

def totalCount = aboveCount + belowCount;

AddLabel(visible = yes, text = "No Of Bars: " + BarNumber() + ", Close Above = " + aboveCount + ", Close Below = " + belowCount + " , Total = " + totalCount, color = Color.LIGHT_GRAY);