Background Color for Watchlist

[bobbyaxelrod]

Hi, I'm having trouble getting background colors to show for a particular script. Right now the background doesn't change color at all, it stays black, though the calculation of the script for "ADR" does work. The full script is below. Any suggestions are much appreciated. Thanks!

#Hint: Average Daily Range

def len = 1;
def price = close;

def dayHigh = DailyHighLow(AggregationPeriod.DAY, len, 0, no).DailyHigh;
def dayLow = DailyHighLow(AggregationPeriod.DAY, len, 0, no).DailyLow;

def ADR = (price - dayLow) / (dayHigh - dayLow)*100;
AddLabel(yes,Round(ADR,0)+"%");

AssignBackgroundColor (if ADR>.80 then Color.GREEN else if ADR>.60 then color.LIGHT_GREEN else if ADR>.40 then color.YELLOW else if ADR>.20 then color.PINK else color.RED);

 

[halcyonguy]

Hi, I'm having trouble getting background colors to show for a particular script. Right now the background doesn't change color at all, it stays black, though the calculation of the script for "ADR" does work. The full script is below. Any suggestions are much appreciated. Thanks!

#Hint: Average Daily Range

def len = 1;
def price = close;

def dayHigh = DailyHighLow(AggregationPeriod.DAY, len, 0, no).DailyHigh;
def dayLow = DailyHighLow(AggregationPeriod.DAY, len, 0, no).DailyLow;

def ADR = (price - dayLow) / (dayHigh - dayLow)*100;
AddLabel(yes,Round(ADR,0)+"%");

AssignBackgroundColor (if ADR>.80 then Color.GREEN else if ADR>.60 then color.LIGHT_GREEN else if ADR>.40 then color.YELLOW else if ADR>.20 then color.PINK else color.RED);

how can you say the adr works, when most of the values are N/A ?

changed a few things. added notes in code. works now.
removed 2nd agg and set column to DAY.

def len = 1;
def price = close;

# 2nd agg causing issues
#def dayHigh = DailyHighLow(AggregationPeriod.DAY, len, 0, no).DailyHigh;
#def dayLow = DailyHighLow(AggregationPeriod.DAY, len, 0, no).DailyLow;
# change formulas.  set column to day
def dayHigh = High;
def dayLow = Low;

def ADR = (price - dayLow) / (dayHigh - dayLow)*100;
# no color, defaults to white , cant read it
#AddLabel(yes,Round(ADR,0)+"%");
# add black so can read the numbers
#AddLabel(yes,Round(ADR,0)+"%", color.black);
# add leading 0 for small numbers, so the text can be sorted in column
AddLabel(yes,
(if adr < 10 then "0" else "") + Round(ADR,0)+"%"
, color.black);

# numbers too small, every cell is green
#AssignBackgroundColor (if ADR>.80 then Color.GREEN else if ADR>.60 then color.LIGHT_GREEN else if ADR>.40 then color.YELLOW else if ADR>.20 then color.PINK else color.RED);

# chg numbers
AssignBackgroundColor (if ADR>80 then Color.GREEN else if ADR>60 then color.LIGHT_GREEN else if ADR>40 then color.YELLOW else if ADR>20 then color.PINK else color.RED);
#

 

[bobbyaxelrod]

Hi @halcyonguy, thank you so much for the help!
I just updated TOS with the new code that you provided and it works perfectly! Interesting that you had a bunch of values show as N/A, as I was able to get that original code that I wrote to do the calculations on my TOS, but not show the background colors due to the errors that you helped correct. Either way, everything is working perfectly with the new and better code that you provided. Also, I really appreciate you providing the #explanations of what you changed and why you changed it, that is very helpful for improving my knowledge of coding on TOS. Thanks again for your help and have a great day!

 

[halcyonguy]

Also, I really appreciate you providing the #explanations of what you changed and why you changed it, that is very helpful for improving my knowledge of coding on TOS. Thanks again for your help and have a great day!

there are comments to the code.
here are a couple more comments

your are trying to plot ADR numbers, but many values are N/A
you are using the same ADR in formula to decide a color.
i know that variables with N/A's cause a black color when used in a bubble color formula.

AssignBackgroundColor (if ADR>80 then Color.GREEN else if ADR>60 then color.LIGHT_GREEN else if ADR>40 then color.YELLOW else if ADR>20 then color.PINK else color.RED);