Previous All-Time High

[shakib3585]

(Code attached needs correction)
Hello All,

I am trying with a script in an attempt to find the last recorded All Time High (ATH) and not the new one (if made). I have been trying with the attached code but with no luck. Can anyone please help in correcting the code to plot the previously recorded ATH?

Thank you very much

def c1 = high[1];
def ATH = highestall(c1);


plot ATH1 = ATH;


ATH1.SetDefaultColor(CreateColor(51,102,255));
ATH1.SetStyle(Curve.SHORT_DASH);
ATH1.SetPaintingStrategy(PaintingStrategy.HORIZONTAL);

Addlabel(yes,"P.ATH: "+ATH1,CreateColor(51,102,255));

 

[halcyonguy]

(Code attached needs correction)
Hello All,

I am trying with a script in an attempt to find the last recorded All Time High (ATH) and not the new one (if made). I have been trying with the attached code but with no luck. Can anyone please help in correcting the code to plot the previously recorded ATH?

Thank you very much

def c1 = high[1];
def ATH = highestall(c1);


plot ATH1 = ATH;


ATH1.SetDefaultColor(CreateColor(51,102,255));
ATH1.SetStyle(Curve.SHORT_DASH);
ATH1.SetPaintingStrategy(PaintingStrategy.HORIZONTAL);

Addlabel(yes,"P.ATH: "+ATH1,CreateColor(51,102,255));

your words are confusing.
'the last' of something on a chart, would be the current one, the one on the right side, the last candle.
do you mean the previous one?
instead of 'not the new one', do you mean 'not the current one' ?


test stocks chart 15min 10day

DOW , CSCO
the first bar is highest, on 1/26. so no previous highest, no 2nd line

DIS 15min 10day
2/8 has the highest, and 3 bars before it is a previous highest


ATH1 is the highest of all highs.
ATH2 is the previous highest high, the value before the current highest high.

#prev_hihi

#https://usethinkscript.com/threads/previous-all-time-high.17903/
#Previous All-Time High

def na = double.nan;
def bn = barnumber();
def h1 = high;
def ATH1 = highestall(h1);

# find highest high
def h2;
if bn == 1 then {
h2 =  h1;
} else {
h2 = max(h1, h2[1]);
}

# find prev highest.
# if h2 has the same high as the highest, then ignore it, by using a value of 0
def ATH2 = highestall(if h2 == ath1 then 0 else h2);

plot z1 = ath1;
plot z2 = if ath2 > 0 then ath2 else na;


#--------------------------
# test stuff

addchartbubble(0, low,
h1 + "\n" +
h2 + "\n" +
ath1 + "\n" +
ath2 + "\n"
, color.yellow, no);

#plot z3 = h2;
#

2 lines, 1 at the highest, and 1 at the previous highest

 

[shakib3585]

your words are confusing.
'the last' of something on a chart, would be the current one, the one on the right side, the last candle.
do you mean the previous one?
instead of 'not the new one', do you mean 'not the current one' ?


test stocks chart 15min 10day

DOW , CSCO
the first bar is highest, on 1/26. so no previous highest, no 2nd line

DIS 15min 10day
2/8 has the highest, and 3 bars before it is a previous highest


ATH1 is the highest of all highs.
ATH2 is the previous highest high, the value before the current highest high.

#prev_hihi

#https://usethinkscript.com/threads/previous-all-time-high.17903/
#Previous All-Time High

def na = double.nan;
def bn = barnumber();
def h1 = high;
def ATH1 = highestall(h1);

# find highest high
def h2;
if bn == 1 then {
h2 =  h1;
} else {
h2 = max(h1, h2[1]);
}

# find prev highest.
# if h2 has the same high as the highest, then ignore it, by using a value of 0
def ATH2 = highestall(if h2 == ath1 then 0 else h2);

plot z1 = ath1;
plot z2 = if ath2 > 0 then ath2 else na;


#--------------------------
# test stuff

addchartbubble(0, low,
h1 + "\n" +
h2 + "\n" +
ath1 + "\n" +
ath2 + "\n"
, color.yellow, no);

#plot z3 = h2;
#

2 lines, 1 at the highest, and 1 at the previous highest

Thank you, Mr. Rocket @halcyonguy !! I will try to be more simplified next time