how to record the highest price within a period

[oldyoungguy]

I am using Heikin Ashi bar chart. I am trying to record the highest price during a period. ThinkScript doesn't allow me to use the def variable to compare with other value. I cannot get it works correctly. Please help.

I expect all the bubbles on the right side should display the value of 284.38.

My code :

def emaLen9 = 9;
def emaLen3dot5 = 3.5;
def priceType = FundamentalType.CLOSE;
def averageType = AverageType.EXPONENTIAL;

def baseTF = GetAggregationPeriod();

def baseTF_mve9 = MovingAverage(averageType, Fundamental(priceType, period = baseTF), emaLen9);
def baseTF_mve3dot5 = MovingAverage(averageType, Fundamental(priceType, period = baseTF), emaLen3dot5);

def baseTF_O = open(period = baseTF);
def baseTF_h = high(period = baseTF);
def baseTF_l = low(period = baseTF);
def baseTF_c = close(period = baseTF);
def baseTF_HAclose = (baseTF_O + baseTF_h + baseTF_l + baseTF_c) / 4;
def baseTF_HAopen = CompoundValue(1, (baseTF_HAopen[1] + baseTF_HAclose[1]) / 2, baseTF_HAclose);
def baseTF_HAhigh = Max(Max(baseTF_h, baseTF_HAopen), baseTF_HAclose);
def baseTF_HAlow = Min(Min(baseTF_l, baseTF_HAopen), baseTF_HAclose);

def baseTF_isCrossedAbove = baseTF_mve3dot5 crosses above baseTF_mve9;
def baseTF_isCrossBelow = baseTF_mve3dot5 crosses below baseTF_mve9;

def baseTF_isCrossBelowBefore;
def baseTF_isCrossAboveBefore;

if(baseTF_isCrossBelow)
{
    baseTF_isCrossBelowBefore = yes;
    baseTF_isCrossAboveBefore = no;
}
else if(baseTF_isCrossedAbove)
{
    baseTF_isCrossBelowBefore = no;
    baseTF_isCrossAboveBefore = yes;
}
else
{
    baseTF_isCrossBelowBefore = baseTF_isCrossBelowBefore[1];
    baseTF_isCrossAboveBefore = baseTF_isCrossAboveBefore[1];
}

def rangeHighest ;

if(baseTF_isCrossAboveBefore)
{
   #if（baseTF_HAhigh > rangeHighest ） #-- shold be like this, but thinkScript doesn't like this, syntex error
   #if(baseTF_HAhigh > baseTF_HAhigh[1] && baseTF_HAhigh > rangeHighest ) #-- no syntex error but nothing show up
    if(baseTF_HAhigh > baseTF_HAhigh[1]) #-- the result is NOT fully correct
    {
        rangeHighest = baseTF_HAhigh;
    }
    else
    {
        rangeHighest =  rangeHighest[1];
    }
}
else
{
    rangeHighest =  rangeHighest[1];
}

AddChartBubble(yes, high, rangeHighest , Color.WHITE, yes);

 

[halcyonguy]

I am using Heikin Ashi bar chart. I am trying to record the highest price during a period. ThinkScript doesn't allow me to use the def variable to compare with other value. I cannot get it works correctly. Please help.


I expect all the bubbles on the right side should display the value of 284.38.

My code :

def emaLen9 = 9;
def emaLen3dot5 = 3.5;
def priceType = FundamentalType.CLOSE;
def averageType = AverageType.EXPONENTIAL;

def baseTF = GetAggregationPeriod();

def baseTF_mve9 = MovingAverage(averageType, Fundamental(priceType, period = baseTF), emaLen9);
def baseTF_mve3dot5 = MovingAverage(averageType, Fundamental(priceType, period = baseTF), emaLen3dot5);

def baseTF_O = open(period = baseTF);
def baseTF_h = high(period = baseTF);
def baseTF_l = low(period = baseTF);
def baseTF_c = close(period = baseTF);
def baseTF_HAclose = (baseTF_O + baseTF_h + baseTF_l + baseTF_c) / 4;
def baseTF_HAopen = CompoundValue(1, (baseTF_HAopen[1] + baseTF_HAclose[1]) / 2, baseTF_HAclose);
def baseTF_HAhigh = Max(Max(baseTF_h, baseTF_HAopen), baseTF_HAclose);
def baseTF_HAlow = Min(Min(baseTF_l, baseTF_HAopen), baseTF_HAclose);

def baseTF_isCrossedAbove = baseTF_mve3dot5 crosses above baseTF_mve9;
def baseTF_isCrossBelow = baseTF_mve3dot5 crosses below baseTF_mve9;

def baseTF_isCrossBelowBefore;
def baseTF_isCrossAboveBefore;

if(baseTF_isCrossBelow)
{
    baseTF_isCrossBelowBefore = yes;
    baseTF_isCrossAboveBefore = no;
}
else if(baseTF_isCrossedAbove)
{
    baseTF_isCrossBelowBefore = no;
    baseTF_isCrossAboveBefore = yes;
}
else
{
    baseTF_isCrossBelowBefore = baseTF_isCrossBelowBefore[1];
    baseTF_isCrossAboveBefore = baseTF_isCrossAboveBefore[1];
}

def rangeHighest ;

if(baseTF_isCrossAboveBefore)
{
   #if（baseTF_HAhigh > rangeHighest ） #-- shold be like this, but thinkScript doesn't like this, syntex error
   #if(baseTF_HAhigh > baseTF_HAhigh[1] && baseTF_HAhigh > rangeHighest ) #-- no syntex error but nothing show up
    if(baseTF_HAhigh > baseTF_HAhigh[1]) #-- the result is NOT fully correct
    {
        rangeHighest = baseTF_HAhigh;
    }
    else
    {
        rangeHighest =  rangeHighest[1];
    }
}
else
{
    rangeHighest =  rangeHighest[1];
}

AddChartBubble(yes, high, rangeHighest , Color.WHITE, yes);

You are checking when a crossing happens,
then checking if a high is higher than a previous high.

that is what happened where you have your arrow on the image. the bar crossed above a line and the high is higher than the previous high, so the value changed in the bubble.

you aren't comparing the current high to a variable holding the highest high of the chart, rangeHighest[1].
you are only comparing the current high to the previous bar high.

def rangeHighest ; if(baseTF_isCrossAboveBefore) {
if(baseTF_HAhigh > baseTF_HAhigh[1]) {
rangeHighest = baseTF_HAhigh;
}
......


Do you want to find the highest high on the chart?

Do you want to find the highest high during each day?

def bn = barnumber();
input reset_high_daily = yes;
def newday = GetDay() <> GetDay()[1];
def hihi = if bn = 1 then 0
else if (reset_high_daily and newday) then high
else if high > hihi[1] then high
else hihi[1];
addchartbubble(1, low, hihi, color.yellow, no);

ps,
your code is overly complicated.

if you are using the same time frame as the chart, you don't need to specify aggregation periods within price functions.

You don't need to specify a price fundamental type close, you can just say close.

functions expect lengths to be integers, not 3.5. you can't read from 1/2 a bar. i haven't tried this, so guessing the number will be rounded down to 3.

if you use an input for defining an average type, Instead of def, then it can be changed in the settings window and you can experiment with different types of averages.

hope this helps. keep asking questions and learning

 

[oldyoungguy]

You are checking when a crossing happens,
then checking if a high is higher than a previous high.

that is what happened where you have your arrow on the image. the bar crossed above a line and the high is higher than the previous high, so the value changed in the bubble.

you aren't comparing the current high to a variable holding the highest high of the chart, rangeHighest[1].
you are only comparing the current high to the previous bar high.

def rangeHighest ; if(baseTF_isCrossAboveBefore) {
if(baseTF_HAhigh > baseTF_HAhigh[1]) {
rangeHighest = baseTF_HAhigh;
}
......


Do you want to find the highest high on the chart?

Do you want to find the highest high during each day?

def bn = barnumber();
input reset_high_daily = yes;
def newday = GetDay() <> GetDay()[1];
def hihi = if bn = 1 then 0
else if (reset_high_daily and newday) then high
else if high > hihi[1] then high
else hihi[1];
addchartbubble(1, low, hihi, color.yellow, no);

ps,
your code is overly complicated.

if you are using the same time frame as the chart, you don't need to specify aggregation periods within price functions.

You don't need to specify a price fundamental type close, you can just say close.

functions expect lengths to be integers, not 3.5. you can't read from 1/2 a bar. i haven't tried this, so guessing the number will be rounded down to 3.

if you use an input for defining an average type, Instead of def, then it can be changed in the settings window and you can experiment with different types of averages.

hope this helps. keep asking questions and learning

Thank you for your help.

Your this sentence resolved my issue:

you aren't comparing the current high to a variable holding the highest high of the chart, rangeHighest[1].

I tried this: if（baseTF_HAhigh > rangeHighest ) .But it should be this: if（baseTF_HAhigh > rangeHighest[1])

My code is from a bigger file involving multi-time frame. I am still new with ThinkScript so the code is not concise and the logic may not be straightforward.

Yes, keep learning!