So the trending conditions are when the 9EMA is less than the 21MA and any one the last 3 candles haven't crossed over the 21MA or when the 9EMA hasn't crossed the 21MA within the last 3 bars (These would be values of 1 or -1). This should be shown in the lower study as the line being in the red (-1) for a downtrend or the green (1) for an uptrend. The ranging conditions are defined in my code to show that the value should be 0 when there has been a change in the last 3 closing bars.
So my question is the why is this value showing 0 when clearly the ranging conditions, which I have listed in the code, are not met. Clearly the appropriate condition would be a downtrend (-1) where the 9EMA is less than the 21MA and the close is less than the 21MA for more than 3 bars.
View attachment 18557
Code:
declare lower;
#Input Moving Average Lengths
input First_MA = 9;
input Second_MA = 21;
#Define Moving Averages and Price
def MA1 = MovAvgExponential(close, First_MA);
def MA2 = SimpleMovingAvg(close, Second_MA);
#def Close_Price = if isNaN(close) then open else close[1];
#Up Trend, Down Trend, & Ranging Conditions
def Up_Trend = MA1 > MA2 and close > MA2;
def Down_Trend = MA1 < MA2 and close < MA2;
def Ranging1 = MA1 > MA2 and close[1] < MA2;
def Ranging2 = MA1 > MA2 and close[2] < MA2;
def Ranging3 = MA1 > MA2 and close[3] < MA2;
def Ranging4 = MA1 < MA2 and close[1] > MA2;
def Ranging5 = MA1 < MA2 and close[2] > MA2;
def Ranging6 = MA1 < MA2 and close[3] > MA2;
def Ranging = Ranging1 or Ranging2 or Ranging3 or Ranging4 or Ranging5 or Ranging6;
#Plot Lower Study Line
plot MyLine = if Ranging then 0 else if Up_Trend then 1 else if Down_Trend then -1 else 0;
#plot MyLine = if Up_Trend then 1 else if Down_Trend then -1 else if Ranging then 0 else double.NaN;
#Define Upper and Lower Bounds
def UpperBound = 0.5;
def LowerBound = -0.5;
AddCloud(-0.5, -1.5, Color.PINK);
AddCloud( 1.5, 0.5, Color.LIGHT_GREEN);
short answer,
you say ' a candle hasn't crossed..'
but are using > and < , with 2 different sets of variables, so the formulas are not checking for a crossing.
----------------
your post1 didn't explain the rules, just a code, so it was confusing.
your post3 words actually explain what you are trying to do.
although it is confusing when reading rules as , 'having a value of 1 or -1'
the rules for each output should be written out separately, for 1 and -1.
----------------
computers only do what they are told.
they don't just make up different outputs.
this statement tells me you are stuck on your beliefs and have not looked at and evaluated the values in my test study, and reevaluated your code formulas.
'...when clearly the ranging conditions, which I have listed in the code, are not met.'
----------------
lets try to rewrite your rules
this is still confusing. what exactly has to happen for a 1 and for a -1 ?
' So the trending conditions are when the 9EMA is less than the 21MA and any one the last 3 candles haven't crossed over the 21MA or when the 9EMA hasn't crossed the 21MA within the last 3 bars (These would be values of 1 or -1). This should be shown in the lower study as the line being in the red (-1) for a downtrend or the green (1) for an uptrend.
The ranging conditions are defined in my code to show that the value should be 0 when there has been a change in the last 3 closing bars. '
you say ' a candle hasn't crossed..'
but are using > and < , with 2 different sets of variables, so the formulas are not checking for a crossing.
my guesses at what you mean
trending up = 1
. ema9 > ma21
. and (no price crossing of ma21 within 3 bars or ema9 has not crossed ma21 within 3 bars)
trending down = -1
. ema9 < ma21
. and (no price crossing of ma21 within 3 bars or ema9 has not crossed ma21 within 3 bars)
trending = 0 , = ranging ?
i don't know why you are adding a new word, ranging, to a condition of trending. it just complicates things.
(price crossed ma21 within 3 bars or ema9 crossed ma21 within 3 bars)
i created formulas for these rules and added them to the end of post3 code.
take a look and see if i have the formulas correct.
#--------------------------------
this is an upper test code , to help you verify the rules.
Code:
#ranging_trending_rules_p3_upper
#https://usethinkscript.com/threads/analyze-problem-with-code.14701/
#post3
#So the trending conditions are when the 9EMA is less than the 21MA and any one the last 3 candles haven't crossed over the 21MA or when the 9EMA hasn't crossed the 21MA within the last 3 bars (These would be values of 1 or -1). This should be shown in the lower study as the line being in the red (-1) for a downtrend or the green (1) for an uptrend. The ranging conditions are defined in my code to show that the value should be 0 when there has been a change in the last 3 closing bars.
#declare lower;
#Input Moving Average Lengths
input First_MA = 9;
input Second_MA = 21;
#Define Moving Averages and Price
def MA1 = MovAvgExponential(close, First_MA);
def MA2 = SimpleMovingAvg(close, Second_MA);
plot z1 = ma1;
plot z2 = ma2;
#def Close_Price = if isNaN(close) then open else close[1];
#Up Trend, Down Trend, & Ranging Conditions
def Up_Trend = MA1 > MA2 and close > MA2;
def Down_Trend = MA1 < MA2 and close < MA2;
def Ranging1 = MA1 > MA2 and close[1] < MA2;
def Ranging2 = MA1 > MA2 and close[2] < MA2;
def Ranging3 = MA1 > MA2 and close[3] < MA2;
def Ranging4 = MA1 < MA2 and close[1] > MA2;
def Ranging5 = MA1 < MA2 and close[2] > MA2;
def Ranging6 = MA1 < MA2 and close[3] > MA2;
def Ranging = Ranging1 or Ranging2 or Ranging3 or Ranging4 or Ranging5 or Ranging6;
#Plot Lower Study Line
def MyLine = if Ranging then 0 else if Up_Trend then 1 else if Down_Trend then -1 else 0;
#plot MyLine = if Up_Trend then 1 else if Down_Trend then -1 else if Ranging then 0 else double.NaN;
#Define Upper and Lower Bounds
def UpperBound = 0.5;
def LowerBound = -0.5;
#AddCloud(-0.5, -1.5, Color.PINK);
#AddCloud( 1.5, 0.5, Color.LIGHT_GREEN);
#-----------------------------
input test1 = no;
AddChartBubble(test1, low,
Ranging
#MyLine
, Color.YELLOW, no);
input test2 = no;
AddChartBubble(test2, low,
Ranging1 + "\n" +
Ranging2 + "\n" +
Ranging3 + "\n" +
Ranging4 + "\n" +
Ranging5 + "\n" +
Ranging6 + "\n"
#+
# Ranging7 + "\n" +
# Ranging8 + "\n" +
# Ranging9 + "\n" +
# Ranging10 + "\n" +
# Ranging11 + "\n" +
# Ranging12 + "\n" +
# Ranging13 + "\n" +
# Ranging14
, (if Ranging then Color.YELLOW else Color.GRAY), no);
#, color.yellow, no);
#
#--------------------------------
input crossing_bars = 3;
#def crossing = (price crossed ma21 within 3 bars or ema9 crossed ma21 within 3 bars)
def crossing1 = close crosses ma1;
def crossing2 = ma1 crosses ma2;
def cross1 = if sum(crossing1, crossing_bars) > 0 then 1 else 0;
def cross2 = if sum(crossing2, crossing_bars) > 0 then 1 else 0;
def trend =
if (ma1 > ma2 and cross1 == 0 and cross2 == 0) then 1
else if (ma1 < ma2 and cross1 == 0 and cross2 == 0) then -1
else if (cross1 or cross2) then 0
else trend[1];
addchartbubble(1, low,
trend + " T\n" +
crossing1 + " x1\n" +
cross1 + " x1cnt\n" +
crossing2 + " x2\n" +
cross2 + " x2cnt"
, (if trend > 0 then color.green else if trend < 0 then color.red else color.gray), no);
#
