Extract the Previous Daily High value and use it on a 1-minute chart label

[shakib3585]

Greetings All,

On a given trading day, I am trying to extract the previous daily high of a given week and compare that with the current daily "open" price. I am trying to use that label on a 1-minute chart. The code I attempted is as follows,

# definition of previous current weekly high = PCWH
def newWeek = GetWeek() <> GetWeek()[1];
def PCWH = if NewWeek then High(period = aggregationPeriod.DAY)else if High(period = aggregationPeriod.DAY) [1] > PCWH[1] then High(period = aggregationPeriod.DAY)[1] else PCWH[1];
def PC_WH = PCWH ;
def open = Open(period = aggregationPeriod.DAY);
def p3 = Open(period = aggregationPeriod.DAY)< PC_WH;


AddLabel(yes, Concat("PCWH: ", PC_WH), Color.oraNGE);
AddLabel(yes, Concat("Open: ", Open(period = aggregationPeriod.DAY)), Color.cyan);
AddLabel(yes, "Status ", if p3 then color.green else color.red);

On a daily time frame, the above code locates the previous daily high of a given week exactly, but when I try to use it on a 1-minute chart, it messes up. Can anyone please help me to fix the code such that I can extract the correct "previous daily high" and use the exact value on a 1minute chart label

Thank you,

Fais

 

[BenTen]

Did you display enough data on your 1m chart? You're retrieving data from the weekly chart, so there must be at least one week of data available even when you're on the 1m chart.

 

[shakib3585]

Did you display enough data on your 1m chart? You're retrieving data from the weekly chart, so there must be at least one week of data available even when you're on the 1m chart.

My current set up on Thinkorswim is " 30D: 1m"...is it enough or do I need more

 

[halcyonguy]

Greetings All,

On a given trading day, I am trying to extract the previous daily high of a given week and compare that with the current daily "open" price. I am trying to use that label on a 1-minute chart. The code I attempted is as follows,

# definition of previous current weekly high = PCWH
def newWeek = GetWeek() <> GetWeek()[1];
def PCWH = if NewWeek then High(period = aggregationPeriod.DAY)else if High(period = aggregationPeriod.DAY) [1] > PCWH[1] then High(period = aggregationPeriod.DAY)[1] else PCWH[1];
def PC_WH = PCWH ;
def open = Open(period = aggregationPeriod.DAY);
def p3 = Open(period = aggregationPeriod.DAY)< PC_WH;


AddLabel(yes, Concat("PCWH: ", PC_WH), Color.oraNGE);
AddLabel(yes, Concat("Open: ", Open(period = aggregationPeriod.DAY)), Color.cyan);
AddLabel(yes, "Status ", if p3 then color.green else color.red);

On a daily time frame, the above code locates the previous daily high of a given week exactly, but when I try to use it on a 1-minute chart, it messes up. Can anyone please help me to fix the code such that I can extract the correct "previous daily high" and use the exact value on a 1minute chart label

Thank you,

Fais

your study displays numbers,
but, today, wed am before the normal opening, a higher high from friday is saved , not the previous day high.
so i don't know what data you want to read to get a high from.


it would help if you could clearly list the rules the study should follow.



i think there is some weird quirk happening with your code.
def PCWH = ...
your formula looks ok, but it is sometimes saving a higher high from last weeks friday...



issues
'messes up' doesn't tell us anything.
if you want help , tell us what is happening. what do you see? what stock? what chart time? after hours turned on?


i don't know what this is supposed to mean. you can't describe something as previous AND current.
# definition of previous current weekly...


why do you mention week, when you want to compare todays open to yesterdays high? what does week have to do with it?
from your formula, def PCWH = ,
on monday , you are comparing monday high to monday open.
then on the next 4 days, you compare the prev day high to the current day open.
on tuesday , you are comparing monday high to tuesday open.


you are defining open. open is a reserved word, it shouldn't be used as a variable name. you may see strange/unexpected values from doing things like this.
this variable isn't being used. when
def open = Open(period = aggregationPeriod.DAY);
https://tlc.thinkorswim.com/center/reference/thinkScript/Functions/Fundamentals

don't need to use 2nd aggregation to find data in the past.

don't need to use concat(). use + to join text objects.


here is my version, to compare yesterdays high to todays open.

def newday = getday() <> getday()[1];
def daycnt = if bn == 1 then 1 else if newday then daycnt[1] + 1 else daycnt[1];
def currentday = getday() == getlastday();
def prevday = getday() + 1 == getlastday();

def prevdayhi = if !prevday then prevdayhi[1]
else if newday then high
else if high > prevdayhi[1] then high
else prevdayhi[1];

def currentdayopen = if newday and
currentday then open
else currentdayopen[1];

def openlower = (currentdayopen < prevdayhi);

AddLabel(1, " ", color.black);

AddLabel(1,
"prev day hi " + prevdayhi
, color.orange);

AddLabel(1,
"Open: " + currentdayopen
, Color.cyan);

AddLabel(1,
"Status" ,
( if openlower then color.green else color.red));
#

 

[shakib3585]

your study displays numbers,
but, today, wed am before the normal opening, a higher high from friday is saved , not the previous day high.
so i don't know what data you want to read to get a high from.


it would help if you could clearly list the rules the study should follow.



i think there is some weird quirk happening with your code.
def PCWH = ...
your formula looks ok, but it is sometimes saving a higher high from last weeks friday...



issues
'messes up' doesn't tell us anything.
if you want help , tell us what is happening. what do you see? what stock? what chart time? after hours turned on?


i don't know what this is supposed to mean. you can't describe something as previous AND current.
# definition of previous current weekly...


why do you mention week, when you want to compare todays open to yesterdays high? what does week have to do with it?
from your formula, def PCWH = ,
on monday , you are comparing monday high to monday open.
then on the next 4 days, you compare the prev day high to the current day open.
on tuesday , you are comparing monday high to tuesday open.


you are defining open. open is a reserved word, it shouldn't be used as a variable name. you may see strange/unexpected values from doing things like this.
this variable isn't being used. when
def open = Open(period = aggregationPeriod.DAY);
https://tlc.thinkorswim.com/center/reference/thinkScript/Functions/Fundamentals

don't need to use 2nd aggregation to find data in the past.

don't need to use concat(). use + to join text objects.


here is my version, to compare yesterdays high to todays open.

def newday = getday() <> getday()[1];
def daycnt = if bn == 1 then 1 else if newday then daycnt[1] + 1 else daycnt[1];
def currentday = getday() == getlastday();
def prevday = getday() + 1 == getlastday();

def prevdayhi = if !prevday then prevdayhi[1]
else if newday then high
else if high > prevdayhi[1] then high
else prevdayhi[1];

def currentdayopen = if newday and
currentday then open
else currentdayopen[1];

def openlower = (currentdayopen < prevdayhi);

AddLabel(1, " ", color.black);

AddLabel(1,
"prev day hi " + prevdayhi
, color.orange);

AddLabel(1,
"Open: " + currentdayopen
, Color.cyan);

AddLabel(1,
"Status" ,
( if openlower then color.green else color.red));
#

Thank you @halcyonguy.

 

[shakib3585]

I was checking my code today and was unable to find my mistake for a given stock's daily price. The target of "PCWH" was to obtain the previous weekly high of the current week. The previous daily high of a given week may or may not be equal to the previous weekly high of the same week. I saw that if I plotted the code only on the daily chart, it worked fine for obtaining PCWH. I have attached the link of HSCS chart for reference .Please correct me if I am wrong @halcyonguy if I am just plotting at Daily timeframe only.

Much appreciated